Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for login via creds file to non-prod envs #99

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ncabatoff
Copy link
Contributor

Changes proposed in this PR:

If a credentials file is used for login, the env vars were ignored, making it impossible to test in e.g. a PRDE. Add a call to FromEnv when using creds file.

How I've tested this PR:

I was trying to test logging in using WIF, and it wasn't finding my WIF provider resource. Debugging revealed it was connecting to the prod hcp, even when I set the appropriate env vars. After I made this change and rebuilt, the resource in my PRDE was found and I was able to complete the login to my PRDE using a creds file.

How I expect reviewers to test this PR:

Checklist:

  • Tests added if applicable
  • CHANGELOG entry added or label 'pr/no-changelog' added to PR

    Run CHANGELOG_PR=<PR number> make changelog/new-entry for guidance
    in authoring a changelog entry, and commit the resulting file, which should
    have a name matching your PR number. Entries should use imperative present
    tense (e.g. Add support for...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant